fix: revert subchunkable to look at 3 chunks, and check for rollover every time #867
+31
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dodamih
force-pushed
the
dodam/blending_fix
branch
from
4cac4a8 to
a320ea5
Compare
dodamih
changed the title
supersergiy
approved these changes
Jan 25, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #867 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 142 142
Lines 6066 6066
=========================================
Hits 6066 6066 ☔ View full report in Codecov by Sentry. |
|
I am OK with merging this to fix the broken blending mode, but adding a test to prevent future regressions would be even better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.