build_image.py: tag->tag_suffix

[supersergiy]

It's unintuitive that the actual docker tag is not identical to --tag argument given to the script. Too much know-how

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (68e5fd1) to head (6757e1f).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #865   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          142       142           
  Lines         6066      6066           
=========================================
  Hits          6066      6066           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nkemnitz]

The python tag was supposed to make it easier catching issues from scheduler and image versions being out of sync. I was even thinking I should add more tags for Pytorch and CUDA version, similar to how their official images are tagged.

Doesn't it show the full image path with name and tag at the end of the build_image.py script? I usually copy it from there, because I can never remember the Artifact Registry repo path.

[nkemnitz]

I guess we could use labels, that would at least allow finding and filtering the image with the correct version.
Maybe the builder could check if scheduler environment and docker image are compatible

[supersergiy]

I see your argument, but I feel like "tag" has very specific meaning in docker context, and overloading it to mean just a part of the tag is confusing. How about we rename that argument to "tag_suffix"?

I've never looked into labels, but it might be a good solution too. Lmk what you prefer

[supersergiy]

@nkemnitz made the change. Couldn't verify it works because I'm having an access issue, but hope that will resolve independently

[nkemnitz]

Sounds good, no objection.