Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): include pcg installation #854

Closed
wants to merge 1 commit into from

Conversation

akhileshh
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (13fa91a) to head (6236bfb).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #854   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          142       142           
  Lines         6031      6034    +3     
=========================================
+ Hits          6031      6034    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akhileshh akhileshh changed the title feat(docker): inclde pcg installation feat(docker): include pcg installation Jan 19, 2025
@akhileshh akhileshh force-pushed the akhilesh/zutils-pcg-docker branch from 6ff9fc9 to 6236bfb Compare January 19, 2025 23:02
Copy link
Collaborator

@nkemnitz nkemnitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case you want to try this approach with the graph tool installation in the zutils image, I would request to cleanup the image from all temporary data, caches and unused apt packages.

@ranlu showed me how to do this for the Pytorch base image: (https://github.com/ZettaAI/zetta_utils/blob/main/docker/pytorch_base/Dockerfile#L122-L140)

&& apt update && apt install git g++ -y \
&& git clone --depth 1 --branch v2.18.3 https://github.com/CAVEconnectome/PyChunkedGraph.git pcg \
&& cd pcg \
&& pip3 install . -r requirements.in
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either pip install --no-cache-dir or use the --mount=type=cache approach above



FROM zutils AS zutils-pcg
RUN conda install graph-tool -c conda-forge -y \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

graph-tool-base avoids all the graph display related dependencies

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup for conda: conda clean -ya

@akhileshh
Copy link
Contributor Author

Thanks! But I think I like your pr better. I have no idea how long re-building the base image is going to take. Don't have the time to experiment with that now.

@akhileshh akhileshh closed this Jan 21, 2025
@akhileshh akhileshh deleted the akhilesh/zutils-pcg-docker branch January 22, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants