Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to cluster generation script #850

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Conversation

nkemnitz
Copy link
Collaborator

  • @akhileshh requested GPU count labels
  • Image streaming requires Service Usage Consumer role

@nkemnitz nkemnitz requested a review from akhileshh January 12, 2025 17:02
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3fd60a3) to head (53aa723).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #850   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          142       142           
  Lines         6036      6036           
=========================================
  Hits          6036      6036           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nkemnitz
Copy link
Collaborator Author

Mypy error unrelated to PR

@nkemnitz nkemnitz merged commit e280705 into main Jan 13, 2025
7 of 10 checks passed
@nkemnitz nkemnitz deleted the nkem/fix-image-stream2 branch January 13, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants