fix: fixes reduction chunk incrementation logic #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dodamih
force-pushed
the
dodam/volumetric_small_chunk_fix
branch
from
cdcbca7 to
cfd6056
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #840 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 142 142
Lines 6031 6031
=========================================
Hits 6031 6031 ☔ View full report in Codecov by Sentry. |
JoeStrout
approved these changes
Jan 7, 2025
supersergiy
force-pushed
the
dodam/volumetric_small_chunk_fix
branch
from
cfd6056 to
a770333
Compare
dodamih
force-pushed
the
dodam/volumetric_small_chunk_fix
branch
2 times, most recently
from
c679a67 to
06541b9
Compare
supersergiy
force-pushed
the
dodam/volumetric_small_chunk_fix
branch
from
06541b9 to
11916fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some pathological cases that occur more commonly with smaller processing chunk sizes. Specifically, the bug happened when the last reduction chunk in a row or a column don't overlap with the processing chunk due to checkerboarding.