Add test_custom_op.py to test RecursionError bug. #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #833 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 142 142
Lines 5958 5958
=========================================
Hits 5958 5958 ☔ View full report in Codecov by Sentry. |
JoeStrout
force-pushed
the
joe/recursion-bug
branch
from
04bd24b to
9079a60
Compare
supersergiy
approved these changes
Dec 17, 2024
JoeStrout
force-pushed
the
joe/recursion-bug
branch
from
9079a60 to
8894802
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this test was written (several months ago), it exposed a bug (threw a RecursionError exception, I think).
Now the test completes successfully, so yay! Seems the bug was fixed. But now we have a test for it, so that's good, right?