Performance optimization in precomp_annotations.subdivide #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #819 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 142 142
Lines 5958 6011 +53
=========================================
+ Hits 5958 6011 +53 ☔ View full report in Codecov by Sentry. |
nkemnitz
reviewed
Oct 30, 2024
JoeStrout
force-pushed
the
joe/opt-precomp_annotations
branch
4 times, most recently
from
37be3ee to
ce48c45
Compare
|
Is this one ready for review? |
|
Yep! |
JoeStrout
force-pushed
the
joe/opt-precomp_annotations
branch
from
1392623 to
619b7e1
Compare
|
Hey @nkemnitz , I pushed some additional changes, but I now hope to quit mucking with this file for a while (and if I do, it'll be in a new branch). Could you please review? |
nkemnitz
reviewed
Dec 16, 2024
(substantially speeds up finalization of large annotation files)
JoeStrout
force-pushed
the
joe/opt-precomp_annotations
branch
from
fb681f4 to
a93f53d
Compare
nkemnitz
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(substantially speeds up finalization of large annotation files)