Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(k8s): wait until backoff_limit is reached for failed jobs #580

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

akhileshh
Copy link
Contributor

@akhileshh akhileshh commented Dec 9, 2023

fixes #524

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6cf3346) 100.00% compared to head (f26dd7c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #580   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          129       129           
  Lines         4305      4305           
=========================================
  Hits          4305      4305           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@supersergiy supersergiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@akhileshh akhileshh merged commit 3184081 into main Dec 9, 2023
@akhileshh akhileshh deleted the akhilesh/fix-job-retry branch December 9, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Training job ignores the PodFailurePolicy(?) and shuts down after node experiences memory pressure
2 participants