feat(train): create single entrypoint #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #553 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 128 128
Lines 4284 4284
=========================================
Hits 4284 4284 ☔ View full report in Codecov by Sentry. |
supersergiy
requested changes
Nov 24, 2023
| num_nodes: int = 1, | ||
| nproc_per_node: int = 1, | ||
| retry_count: int = 3, | ||
| local_run: bool = False, |
There was a problem hiding this comment.
probably should be True by default
| torch_launcher_api.elastic_launch(config, _parse_spec_and_train)() | ||
|
|
||
|
|
||
| def _lightning_train( |
There was a problem hiding this comment.
maybe rename to _lightning_train_local
| "full_state_ckpt_path": full_state_ckpt_path, | ||
| } | ||
|
|
||
| _create_ddp_master_job( |
There was a problem hiding this comment.
maybe rename to _lightning_train_remote
|
|
||
| train_spec = { | ||
| "@type": "lightning_train", | ||
| "regime": regime, |
There was a problem hiding this comment.
should prolly use [builder lookup here
supersergiy
reviewed
Nov 25, 2023
| "regime": builder.get_initial_builder_spec(regime), | ||
| "trainer": builder.get_initial_builder_spec(trainer), | ||
| "train_dataloader": builder.get_initial_builder_spec(train_dataloader), | ||
| "val_dataloader": builder.get_initial_builder_spec(val_dataloader), |
There was a problem hiding this comment.
I think we gotta check if any of these are None here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.