Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defect and resin detector #550

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Add defect and resin detector #550

merged 3 commits into from
Nov 27, 2023

Conversation

trivoldus28
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb45713) 100.00% compared to head (54b4e2c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #550   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          128       128           
  Lines         4284      4282    -2     
=========================================
- Hits          4284      4282    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@supersergiy supersergiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this as is for now, but I'm wondering if the old-school tiling in the processor is actually any better than subchunkable here

@supersergiy
Copy link
Member

@trivoldus28 could you address the pylint errors here?

@trivoldus28 trivoldus28 merged commit 4c8e97e into main Nov 27, 2023
11 checks passed
@trivoldus28 trivoldus28 deleted the tri/defect-detector branch November 27, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants