Skip to content

Commit

Permalink
tests: update missed coverage in db layer
Browse files Browse the repository at this point in the history
  • Loading branch information
akhileshh authored and supersergiy committed May 17, 2024
1 parent dd2c0ec commit 1e7ae59
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions tests/unit/layer/db_layer/datastore/test_backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ def test_read_write_simple(datastore_emulator) -> None:

entity = layer.backend.client.get(child_key) # type: ignore
assert entity["value"] == "val"
assert layer.get("key") == "val"
assert layer.get("non_existent_key") is None
assert layer.get("non_existent_key", "default_val") == "default_val"


def test_read_write(datastore_emulator) -> None:
Expand All @@ -46,6 +49,7 @@ def test_read_write(datastore_emulator) -> None:

data = layer[idx_user]
assert data == data_user
assert layer[("key0", "col1")] == "val1"


def test_with_changes(datastore_emulator) -> None:
Expand Down
2 changes: 1 addition & 1 deletion zetta_utils/layer/db_layer/datastore/backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def __contains__(self, idx: str) -> bool:
parent_key = self.client.key("Row", idx)
return self.client.get(parent_key) is not None

def __len__(self) -> int:
def __len__(self) -> int: # pragma: no cover # no emulator support
count_query = self.client.aggregation_query(self.client.query(kind="Row")).count()
for aggregation_results in count_query.fetch():
for aggregation in aggregation_results:
Expand Down
2 changes: 1 addition & 1 deletion zetta_utils/layer/db_layer/layer.py
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ def __setitem__(self, idx, data):
def __contains__(self, idx: str) -> bool: # pragma: no cover # no logic
return idx in self.backend

def __len__(self) -> int:
def __len__(self) -> int: # pragma: no cover # no logic
return len(self.backend)

def get(self, idx: str, default=None):
Expand Down

0 comments on commit 1e7ae59

Please sign in to comment.