Add EmissionFactorDS data model and update schema and fixtures #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for NonEmptyString The specification and the data model deviated in terms of what was expected for the secondaryEmissionFactorSources field. A list of str was being provided, which was incorrect. This represents the introduction of the new type, along with a base type that is a type alias of string to implement NonEmptyString, in order to more closely align with the specification. The next commit will be the introduction and rewriting of module code and tests to reflect this change.
This change uses the EmissionFactorDS data model introduced in the previous commit, along with updating the tests to use a single isolated and consistent CarbonFootprint fixture, as there was too much separation and changes were required in multiple places to reflect API schema changes, this has reduced code complexity significantly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ignore branch name, these changes were larger than first intended, so I've shipped them separately..