Rm datamapper #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…revious version to current without losing data
… and column addition.
|
still considered experimental last time I remember touching it; pry's need to be pulled out at a minimum if you think it runs well enough to merge. I'd test it heavily first though tbh. |
|
4.5 hour plane ride, it's been tested a bit. yeah, I'll pull the prys now. I checked the comments on the pwnie PR and looks like it was mostly --no-db being broken and me not liking the hardcoding of the db location. I will rebase and fix the hardcoding next. mostly just wanted to make sure my removal of limit 1 wasn't an issue. it errored with it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey @dallaswinger can I get a review here?