Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap server/environment setup tasks to follow dependencies #145

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

combscCode
Copy link

👋

small simple change to your readme, moved druid setup before the web setup, since the web setup depends on the druid setup

cheers! 🎉

Copy link
Collaborator

@Sybrand Sybrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@combscCode thanks for the pull request, and interest in Harmony.

Two points to consider:

  1. The issue with ordering goes beyond druid and web setup unfortunately. There's a lot of chicken and egg happening here. Moving druid ahead of web isn't actually enough. The pipeline is also dependent on the Druid server. (This change is a step in the right direction, but would actually have to go before pipeline server setup).

  2. We're intending to move the README.md largely to https://github.com/Zenysis/Harmony/wiki , since it's gotten a bit unwieldy in the source code. So we don't actually want to spend too much time here.

I think however, moving druid setup higher up is a good idea, and something that we can merge in now, and move to the wiki at a later point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants