Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Minor cleanups #9198

Merged
merged 6 commits into from
Feb 4, 2025
Merged

chore: Minor cleanups #9198

merged 6 commits into from
Feb 4, 2025

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Feb 3, 2025

Motivation

Resolve #9139 (comment) and #9139 (comment) and a few other nits.

Tests

N/A

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

@upbqdn upbqdn added A-docs Area: Documentation C-testing Category: These are tests P-Critical 🚑 labels Feb 3, 2025
@upbqdn upbqdn self-assigned this Feb 3, 2025
@upbqdn upbqdn requested review from a team as code owners February 3, 2025 20:58
@upbqdn upbqdn requested review from arya2 and removed request for a team February 3, 2025 20:58
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Feb 3, 2025
oxarbitrage
oxarbitrage previously approved these changes Feb 3, 2025
View reviewed changes
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 4, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #9198 has been dequeued. The pull request rule doesn't match anymore

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

mergify bot added a commit that referenced this pull request Feb 4, 2025
@mergify
Merge of #9198
b212f88
@mergify mergify bot mentioned this pull request Feb 4, 2025
Closed
@mergify mergify bot merged commit a5a1cdf into main Feb 4, 2025
200 checks passed
@mergify mergify bot deleted the chore-cleanup-fixes branch February 4, 2025 03:29
@mpguerra mpguerra linked an issue Feb 4, 2025 that may be closed by this pull request
The tx verifier does not enforce using the correct consensus branch ID in the SIGHASH precomputation #9089
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 approved these changes

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees

@upbqdn upbqdn

Labels
A-docs Area: Documentation C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Critical 🚑
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The tx verifier does not enforce using the correct consensus branch ID in the SIGHASH precomputation
3 participants
@upbqdn @arya2 @oxarbitrage