Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): use a bigger machine for config file tests #8088

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

gustavovalverde
Copy link
Member

Motivation

We've been having this issue from time to time, but as there's nothing in the Zebra config or on the Rust side that could cause this issue, and all the other similar tests are passing, the most probable cause is we're using more memory than the default runners from GitHub are giving us when using this configuration.

Note: Removing the exec command should be our last resort if this does not work by any means.

Closes: #7898

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

  • Use a bigger runner with more memory. In this case ubuntu-latest-m

Testing

Run this test at least 5 times. It should be really fast to do.

Review

Nothing specific.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@gustavovalverde gustavovalverde added C-bug Category: This is a bug A-infrastructure Area: Infrastructure changes A-devops Area: Pipelines, CI/CD and Dockerfiles P-Medium ⚡ I-integration-fail Continuous integration fails, including build and test failures labels Dec 11, 2023
@gustavovalverde gustavovalverde self-assigned this Dec 11, 2023
@gustavovalverde gustavovalverde requested a review from a team as a code owner December 11, 2023 21:27
@gustavovalverde gustavovalverde requested review from upbqdn and removed request for a team December 11, 2023 21:27
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Dec 11, 2023
@teor2345
Copy link
Contributor

Let's also merge this failure fix

mergify bot added a commit that referenced this pull request Dec 11, 2023
@mergify mergify bot merged commit fc478eb into main Dec 11, 2023
101 checks passed
@mergify mergify bot deleted the fix-config-test-fail branch December 11, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-infrastructure Area: Infrastructure changes C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault in main branch Docker Unit Tests
2 participants