Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): use official codespell action #8087

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix(ci): use official codespell action #8087

merged 1 commit into from
Dec 11, 2023

Conversation

gustavovalverde
Copy link
Member

Motivation

Codespell has been failing based on an upstream error in the GitHub Action repo. We're taking this opportunity to use the new official version.

Fixes #8081

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

Complex Code or Requirements

None

Solution

  • Change plettich/action-codespell@master with codespell-project/[email protected]
  • Keep the same options

Testing

Confirm this is running as expected.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

@gustavovalverde gustavovalverde added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-High 🔥 I-integration-fail Continuous integration fails, including build and test failures labels Dec 11, 2023
@gustavovalverde gustavovalverde self-assigned this Dec 11, 2023
@gustavovalverde gustavovalverde requested a review from a team as a code owner December 11, 2023 20:57
@gustavovalverde gustavovalverde requested review from oxarbitrage and removed request for a team December 11, 2023 20:57
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Dec 11, 2023
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this now so we can see which PRs pass

@gustavovalverde
Copy link
Member Author

This is making the annotations as expected here: https://github.com/ZcashFoundation/zebra/pull/8087/files and not failing as it's optional.

@mergify mergify bot merged commit 9ae5585 into main Dec 11, 2023
93 checks passed
@mergify mergify bot deleted the fix-codespell branch December 11, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codespell is failing in all new PRs
2 participants