Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(ci): Split experimental feature tests into their own step #8039

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Nov 30, 2023

Motivation

This PR will make ticket #8037 easier to do, by making it easier to find and read the log output.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

  • Split the experimental feature test output into its own step, so it's easier to find
  • Reduce log output during tests by only logging a checkpoint warning once (rather than for each checkpoint)

Testing

The existing tests cover these changes.

Review

This is a low priority cleanup.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

Actually fix and enable #8037

@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup P-Low ❄️ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG A-blockchain-scanner Area: Blockchain scanner of shielded transactions labels Nov 30, 2023
@teor2345 teor2345 self-assigned this Nov 30, 2023
@teor2345 teor2345 requested review from a team as code owners November 30, 2023 23:15
@teor2345 teor2345 requested review from arya2 and removed request for a team November 30, 2023 23:15
@github-actions github-actions bot added the C-feature Category: New features label Nov 30, 2023
@teor2345 teor2345 removed the C-feature Category: New features label Dec 4, 2023
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

mergify bot added a commit that referenced this pull request Dec 5, 2023
@mergify mergify bot merged commit 05a28b9 into main Dec 6, 2023
162 checks passed
@mergify mergify bot deleted the ci-tweaks branch December 6, 2023 00:52
@mpguerra mpguerra linked an issue Dec 11, 2023 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run Zebra's unit tests with the scanner enabled
2 participants