Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement parital equality for key types #101

Closed
wants to merge 1 commit into from
Closed

Implement parital equality for key types #101

wants to merge 1 commit into from

Conversation

justinabrahms
Copy link
Contributor

No description provided.

@mpguerra mpguerra requested a review from conradoplg November 7, 2023 20:03
@conradoplg
Copy link
Contributor

Thanks for the PR! Is there a particular reason for wanting this? I see that most cryptography crates don't implement PartialEq for private keys. There may be side-channel concerns...

@justinabrahms
Copy link
Contributor Author

We have data structures in our code base which use keys to represent user devices. We'd like to implement equality for that data structure for use in tests.

@conradoplg conradoplg mentioned this pull request Nov 22, 2023
Merged
@conradoplg
Copy link
Contributor

I changed it to use constant-time comparison, so I'm closing this in favor of #102. Thanks!

@conradoplg conradoplg closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradoplg conradoplg Awaiting requested review from conradoplg

Assignees
No one assigned
Labels
None yet
Projects
FROST
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinabrahms @conradoplg