Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z modal/block page scroll #509

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

saldomik
Copy link
Collaborator

@saldomik saldomik commented Feb 4, 2025

Feat - Z-Modal - block page scroll

Motivation and Context

Priority

  • 1 - Highest
  • 2 - High
  • 3 - Medium
  • 4 - Low
  • 5 - Lowest
  • 6 - Not a Priority

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Component (add a Component as approved by Design System)
  • Docs (add documentation)
  • Chore (changes that adds small enhancement)
  • Breaking (fix or feature that would cause existing functionality to not work as expected)

Design

Screenshots

Note

@OleksandrOleksyuk
Copy link
Collaborator

Su storybook quando è attiva questa modale puoi scrollare sotto
image

@OleksandrOleksyuk
Copy link
Collaborator

Su storybook quando è attiva questa modale puoi scrollare sotto image

Credo che sia dovuto perché chiudi l'altra modale e allora va a resettare la logica del overflow

src/components/z-modal/index.tsx Outdated Show resolved Hide resolved
src/components/z-modal/test.e2e.ts Outdated Show resolved Hide resolved
src/components/z-modal/test.e2e.ts Show resolved Hide resolved
src/components/z-modal/test.e2e.ts Outdated Show resolved Hide resolved
src/components/z-modal/test.e2e.ts Outdated Show resolved Hide resolved
src/components/z-modal/test.e2e.ts Outdated Show resolved Hide resolved
src/components/z-modal/test.e2e.ts Show resolved Hide resolved
src/components/z-modal/test.e2e.ts Show resolved Hide resolved
@PaoloFrancesco-Marino PaoloFrancesco-Marino requested review from OleksandrOleksyuk and removed request for veronicavannini February 7, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants