Merge pull request #357 from PierreYvesR/CancellationTokenDispose

Remoting.Client: dispose of the CancellationTokenRegistration when done
Zaid-Ajaj · Jan 8, 2024 · 35ec835 · 35ec835
2 parents 92cabee + 77f7abe
commit 35ec835
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/Fable.Remoting.Client/Http.fs b/Fable.Remoting.Client/Http.fs
@@ -56,10 +56,11 @@ module Http =
             | Some f ->  f xhr
             | _ -> ignore()
 
-            token.Register(fun _ ->
-                xhr.abort()
-                cancel(System.OperationCanceledException(token))
-            ) |> ignore
+            let cancellationTokenRegistration =
+                token.Register(fun _ ->
+                    xhr.abort()
+                    cancel(System.OperationCanceledException(token))
+                )
 
             // set the headers, must be after opening the request
             for (key, value) in req.Headers do
@@ -70,6 +71,7 @@ module Http =
             xhr.onreadystatechange <- fun _ ->
                 match xhr.readyState with
                 | ReadyState.Done when not token.IsCancellationRequested ->
+                    (cancellationTokenRegistration :> System.IDisposable).Dispose()
                     xhr |> resultMapper |> resolve
                 | _ -> ignore()