Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZFIN-9435: UniProt Load Report Improvements #1291

Closed
wants to merge 32 commits into from

Conversation

rtaylorzfin
Copy link
Collaborator

Improve the reports for uniprot load including smaller output files.
Cross check deleted uniprot accessions against NCBI to see if there is an obsolete RefSeq involved in the mapping.

Improve structure of code for generating uniprotDatFile information in the report output.
Add RefSeqs to DELETE's portion of report.
Fix RefSeq parsing
Move the uniprotDatFile information from each individual action to its own map. Then the entries from the map can be referenced by the 'uniprotAccessions' field on each action.
Extract method to make the logic easier to follow and more explicit in what it does.
Extract method to make the logic easier to follow and more explicit in what it does.
Use state of zfin db for determining if a uniprot record is linked to any genes or not
Allow removing more than one accession per gene.
Add more info to the summary of the report.
…clude information about obsoleted RefSeqs (if we find that information).
@rtaylorzfin
Copy link
Collaborator Author

Test harness class:

image

@rtaylorzfin rtaylorzfin marked this pull request as draft January 21, 2025 17:00
@rtaylorzfin rtaylorzfin marked this pull request as ready for review January 22, 2025 16:28
Make IDs copyable for antibody, company, lab, person views.
Don't show an empty orcid link if there's no orcid.
Copy link
Collaborator

@cmpich cmpich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I'll need a walk-through at another time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants