-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZFIN-9435: UniProt Load Report Improvements #1291
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve structure of code for generating uniprotDatFile information in the report output. Add RefSeqs to DELETE's portion of report.
Fix RefSeq parsing
Move the uniprotDatFile information from each individual action to its own map. Then the entries from the map can be referenced by the 'uniprotAccessions' field on each action.
Extract method to make the logic easier to follow and more explicit in what it does.
Extract method to make the logic easier to follow and more explicit in what it does.
Use state of zfin db for determining if a uniprot record is linked to any genes or not
Allow removing more than one accession per gene. Add more info to the summary of the report.
…clude information about obsoleted RefSeqs (if we find that information).
…mmand directly to fix proxy problem.
(cherry picked from commit 8dfa7b7)
Make IDs copyable for antibody, company, lab, person views. Don't show an empty orcid link if there's no orcid.
…ignore those DELETEs
cmpich
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I'll need a walk-through at another time.
Bundle of all changes from the tomcat10 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the reports for uniprot load including smaller output files.
Cross check deleted uniprot accessions against NCBI to see if there is an obsolete RefSeq involved in the mapping.