Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Help needed] use pyproject.toml and poetry #278

Closed
wants to merge 36 commits into from
Closed

[Help needed] use pyproject.toml and poetry #278

wants to merge 36 commits into from

Conversation

glyh
Copy link
Collaborator

@glyh glyh commented Apr 16, 2024

简介

继续 #277, 关闭 #233。方便之后data/ 分开维护

TODO

  • 修复github workflow
    • 增加Caching
    • 使用Bash,poetry 的github workflow似乎只支持bash。
    • 修复Flake8 Linting
    • 修复Windows下构建成功但是运行失败的问题,需要@Yuukiy帮助。
  • 修复windows下的构建 已经被make.py替代
  • 修复mei_path查找
  • 修复pytest测试

Content

  • 重新设计项目结构,把多个package合成一个
  • 删除linux.spec和windows.spec,使用统一的build.spec
  • 将data/ 文件夹重新组织
  • 删除make.bashmake.bat,用make.py代替

如何使用?

  • 首先安装poetry
  • 之后,依次执行:
$ git clone https://github.com/Yuukiy/JavSP.git
$ cd JavSP
$ poetry install # 安装所有依赖
$ poetry run javsp # 以python运行JavSP,或者在venv中运行`python -m javsp`
$ poetry run pytest # 运行所有测试,或者在venv中运行`pytest`也可以
$ poetry run make # 构建二进制EXE,或者在venv中运行`python make/make.py`
$ poetry shell # 进入venv
  • 对于不想使用poetry的用户,可以继续使用pip来构建并且用python -m javsp来打开程序。

潜在问题

一些依赖强制更新到了python 3.9

@glyh glyh marked this pull request as draft April 16, 2024 12:19
@glyh glyh changed the title [Help needed] use pyproject.toml and poetry system [Help needed] use pyproject.toml and poetry Apr 16, 2024
@glyh glyh changed the title [Help needed] use pyproject.toml and poetry [Help needed] use pyproject.toml and poetry Apr 16, 2024
@glyh glyh marked this pull request as ready for review April 16, 2024 13:55
@glyh glyh marked this pull request as draft April 16, 2024 13:55
@glyh
Copy link
Collaborator Author

glyh commented Apr 16, 2024

这个PR太大了,而且感觉更换poetry现在来看并不是个明智的选择,我稍后会push几个小一点的PR。

@glyh glyh closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant