Merge pull request #369 from YunoHost/fix_tests

test: Fix usage of deprecated non-str cookies
YunoHost · Dec 4, 2024 · 61610ce · 61610ce
2 parents b479b17 + 2fbf88c
commit 61610ce
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/test/src/authenticators/dummy.py b/test/src/authenticators/dummy.py
@@ -19,6 +19,7 @@
 #
 
 import logging
+import json
 from moulinette.utils.text import random_ascii
 from moulinette.core import MoulinetteError, MoulinetteAuthenticationError
 from moulinette.authentication import BaseAuthenticator
@@ -56,7 +57,7 @@ def set_session_cookie(self, infos):
 
         response.set_cookie(
             "moulitest",
-            new_infos,
+            json.dumps(new_infos),
             secure=True,
             secret=session_secret,
             httponly=True,
@@ -68,6 +69,7 @@ def get_session_cookie(self, raise_if_no_session_exists=True):
 
         try:
             infos = request.get_cookie("moulitest", secret=session_secret, default={})
+            infos = json.loads(infos)
         except Exception:
             if not raise_if_no_session_exists:
                 return {"id": random_ascii()}

diff --git a/test/src/authenticators/yoloswag.py b/test/src/authenticators/yoloswag.py
@@ -19,6 +19,7 @@
 #
 
 import logging
+import json
 from moulinette.utils.text import random_ascii
 from moulinette.core import MoulinetteError, MoulinetteAuthenticationError
 from moulinette.authentication import BaseAuthenticator
@@ -56,7 +57,7 @@ def set_session_cookie(self, infos):
 
         response.set_cookie(
             "moulitest",
-            new_infos,
+            json.dumps(new_infos),
             secure=True,
             secret=session_secret,
             httponly=True,
@@ -68,6 +69,7 @@ def get_session_cookie(self, raise_if_no_session_exists=True):
 
         try:
             infos = request.get_cookie("moulitest", secret=session_secret, default={})
+            infos = json.loads(infos)
         except Exception:
             if not raise_if_no_session_exists:
                 return {"id": random_ascii()}