Ps updates #11
Open
Ps updates #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csalas-yubico
requested changes
Oct 14, 2024
There was a problem hiding this comment.
I'm not following the reason for this change. Is there a reason we're changing this one to a String, but not the correlated field in the action output?
| @@ -67,11 +67,11 @@ Use the right facing arrow to move the following fields to the column on the rig | |||
| - street_address | |||
| - apt_or_unit | |||
| - city | |||
| - region | |||
There was a problem hiding this comment.
If I'm not mistaken, I think these variable names are "auto populated" by the labels that are configured here
So either we need to mention in the previous page to use the "custom" labels denoted below, or revert back so that the naming is consistent
There was a problem hiding this comment.
See the inner comment on the variable names provided by the catalog item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor updates for typos in text and screen shots.
One functional change to parse the signing keys json before sending it to Okta.