Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid PHP 8.4 deprecations #593

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

brotkrueml
Copy link
Contributor

Summary

This PR can be summarized in the following changelog entry:

  • Avoid PHP 8.4 deprecations

Details

Fix the following deprecation messages when running typo3 cache:flush on console:

PHP Deprecated:  YoastSeoForTypo3\YoastSeo\Backend\PageLayoutHeader::render(): Implicitly marking parameter $params as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/yoast-seo-for-typo3/yoast_seo/Classes/Backend/PageLayoutHeader.php on line 27
PHP Deprecated:  YoastSeoForTypo3\YoastSeo\Controller\AbstractBackendController::returnResponse(): Implicitly marking parameter $moduleTemplate as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/yoast-seo-for-typo3/yoast_seo/Classes/Controller/AbstractBackendController.php on line 25
PHP Deprecated:  YoastSeoForTypo3\YoastSeo\EventListener\RecordCanonicalListener::__construct(): Implicitly marking parameter $recordService as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/yoast-seo-for-typo3/yoast_seo/Classes/EventListener/RecordCanonicalListener.php on line 16
PHP Deprecated:  YoastSeoForTypo3\YoastSeo\MetaTag\Generator\AbstractGenerator::__construct(): Implicitly marking parameter $managerRegistry as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/yoast-seo-for-typo3/yoast_seo/Classes/MetaTag/Generator/AbstractGenerator.php on line 19
PHP Deprecated:  YoastSeoForTypo3\YoastSeo\PageTitle\RecordPageTitleProvider::__construct(): Implicitly marking parameter $recordService as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/yoast-seo-for-typo3/yoast_seo/Classes/PageTitle/RecordPageTitleProvider.php on line 16
PHP Deprecated:  YoastSeoForTypo3\YoastSeo\Utility\JavascriptUtility::loadJavascript(): Implicitly marking parameter $pageRenderer as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/yoast-seo-for-typo3/yoast_seo/Classes/Utility/JavascriptUtility.php on line 13

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fix the following deprecation messages:

    PHP Deprecated:  YoastSeoForTypo3\YoastSeo\Backend\PageLayoutHeader::render(): Implicitly marking parameter $params as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/yoast-seo-for-typo3/yoast_seo/Classes/Backend/PageLayoutHeader.php on line 27
    PHP Deprecated:  YoastSeoForTypo3\YoastSeo\Controller\AbstractBackendController::returnResponse(): Implicitly marking parameter $moduleTemplate as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/yoast-seo-for-typo3/yoast_seo/Classes/Controller/AbstractBackendController.php on line 25
    PHP Deprecated:  YoastSeoForTypo3\YoastSeo\EventListener\RecordCanonicalListener::__construct(): Implicitly marking parameter $recordService as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/yoast-seo-for-typo3/yoast_seo/Classes/EventListener/RecordCanonicalListener.php on line 16
    PHP Deprecated:  YoastSeoForTypo3\YoastSeo\MetaTag\Generator\AbstractGenerator::__construct(): Implicitly marking parameter $managerRegistry as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/yoast-seo-for-typo3/yoast_seo/Classes/MetaTag/Generator/AbstractGenerator.php on line 19
    PHP Deprecated:  YoastSeoForTypo3\YoastSeo\PageTitle\RecordPageTitleProvider::__construct(): Implicitly marking parameter $recordService as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/yoast-seo-for-typo3/yoast_seo/Classes/PageTitle/RecordPageTitleProvider.php on line 16
    PHP Deprecated:  YoastSeoForTypo3\YoastSeo\Utility\JavascriptUtility::loadJavascript(): Implicitly marking parameter $pageRenderer as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/yoast-seo-for-typo3/yoast_seo/Classes/Utility/JavascriptUtility.php on line 13
@RinyVT
Copy link
Collaborator

RinyVT commented Jan 28, 2025

Thanks for the PR!
This will be released with the new major release :)

@RinyVT RinyVT merged commit bcf086b into Yoast:main Jan 28, 2025
4 checks passed
@brotkrueml brotkrueml deleted the avoid-php84-deprecations branch January 28, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants