Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate certificate date against the IssueDate instead of current time #245

Merged
merged 2 commits into from
Feb 4, 2024

Conversation

remia
Copy link
Collaborator

@remia remia commented Feb 1, 2024

From DCI Specifications 1.4.4:

The CPL meets the two validation requirements defined in Section 5.2.1. of SMPTE 430-5 "D-Cinema Operations – Security Log Event Class and Constraints for D-Cinema" with the following caveat: When performing Step 9 of Section 6.2 in SMPTE ST 430-2, the desired time of the validation context shall be equal to the IssueDate field of the target CPL (and not the current time). This behavior permits the continued playback of a CPL after the expiration of its signing certificate, but ensures that the signing took place during the certificate's validity period.

@jamiegau
Copy link
Contributor

jamiegau commented Feb 1, 2024

A full breakdown of the error, who it affects. More info than you want about this issue..

https://www.isdcf.com/certs-expiring/

@remia
Copy link
Collaborator Author

remia commented Feb 1, 2024

Thinking only now but should we keep a Warning / Info if the check fail when validation (wrongly) with the current date? Mostly for EOL playback systems that are not going to get the upgrade?

@jamiegau
Copy link
Contributor

jamiegau commented Feb 1, 2024

Sounds reasonable. Or people are too lazy to update those systems that will be getting upgrades to address it..

@remia remia merged commit d2d4335 into Ymagis:develop Feb 4, 2024
10 checks passed
@remia remia deleted the fix-cert-sign-date branch February 16, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move "Certificate signature check failure : certificate has expired" error to a warning or ignore
2 participants