Support python 3.7 #115
Merged
Support python 3.7 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thriftpy is deprecated and doesn't compile on python 3.7. thriftpy2 is the new version which is still under support and it works fine on py37.
|
This looks great, thanks! Any idea on a timeline for getting this merged and released? Thanks! |
|
I just want to try this in one of our existing codebases that use thriftpy, to make sure thriftpy and thriftpy2 can coexist. Hopefully I can get this merged by this afternoon |
|
@drolando : Thank you! |
|
OK, I just verified that thriftpy and thriftpy2 can be installed together in the same virtualenv and can be imported successfully. |
|
lg2m! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thriftpyis deprecated and doesn't compile onpython 3.7.thriftpy2isthe new version which is still under support and it works fine on
py37.Upstream issue: Thriftpy/thriftpy#333
Related issue: pantsbuild/pants#7147
cc @stuhood @illicitonion