Upstream #2
Open
Upstream #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added configuration options, including environment variables to control the polling No-Issue --------- Signed-off-by: James Tanner <[email protected]> Co-authored-by: s-hertel <[email protected]> Co-authored-by: Jordan Borean <[email protected]>
…if galaxy.yml has empty `version` (#83831) * Do not create invalid SemanticVersion objects. * Fix SemanticVersion.parse(). * Add basic runtime-metadata tests.
we just set time also, when on diff partitions
* the test was previously passing erroneously due to the `timeout` elapsing in CI, and that the `failed` test does not encompass `unreachable`
Expands the test matrix used for testing on Windows to cover the three connection plugins we support for all the tasks. This change also changes how raw commands are run over SSH to avoid starting a `powershell.exe` process that was uneeded in the majority of cases used in Ansible. This simplifies our code a bit more by removing extra Windows specific actions in the ssh plugin and improves the efficiency when running tasks.
The display names need to be set so code coverage reporting works.
The `annotations` future can now be imported as `_annotations`.
Adds the datastore details to the parser error when attempting to include tasks that contain include_tasks without a filename set. This change will now display the exact location of the include_tasks that failed like any normal syntax error.
* psrp - Remove extras lookups Removed the extras variable lookups for the psrp connection plugin. All valid options are already documented and the extras functionality is slated to be deprecated at a future point in time. This should have affect on existing user's playbooks. * Fix up sanity tests and add explicit boolean conversion test
* Add DaemonThreadPoolExecutor impl * Provide a simple parallel execution method with the ability to abandon timed-out operations that won't block threadpool/process shutdown, and without a dependency on /dev/shm (as multiprocessing Thread/Process pools have). * Create module_utils/_internal to ensure that this is clearly not supported for public consumption.
* release.py - Add missing setuptools arg to prepare This allows the prepare command to accept the `--no-setuptools` argument. It also fixes a traceback when using the `prepare` command. * Use a more accurate type hint
* add a loop_control break_when directive to break out of a loop after any item
* remove loop var as normal exit would
* example usage:
- name: generate a random password up to 10 times, until it matches the policy
set_fact:
password: "{{ lookup('password', '/dev/null', chars=character_set, length=length) }}"
loop: "{{ range(0, 10) }}"
loop_control:
break_when:
- password is match(password_policy)
Co-authored-by: s-hertel <[email protected]>
Typo error in examples
* delay keyword changed from int to float * draft test * fixed test * expanded test, fixed 'name' tests also * cleanup * fix
It's been discouraged for the past decade. And CPython actually ships with pip nowadays, that is bundled within the built-in `ensurepip` stdlib module.
also remove redundant and wrong test
Use the changelog sanity test requirements instead of the package-data sanity test requirements. This enables removal of most package-data sanity test requirements, as they are no longer used by the test itself. The additional requirements were being maintained only to provide pinned requirements for building the changelog during a release.
Also update the platform list: * Remove linux ppc64le * Add darwin arm64
* Fact gathering fix 'no shm' branhc * Use concurrent.futures instead of multiprocessing This entirely avoids the need for fallback logic since the concurrent.futures thread pool does not depend on `/dev/shm`. Co-authored-by: Matt Clay <[email protected]>
Avoid check description, better comments
Instead of re-using the token used in impersonation, this change will create a new token for the SYSTEM account as returned by LogonUser. The benefits of this is that the token will contain the full privileges for the SYSTEM account rather than potentially one that has restricted privileges we used during impersonation. It should also help avoid problems on Windows that fails on status 0x0000016F when the impersonated token during become was from a process that is restricted from creating sub processes.
* update communication details in README * update comms details in contributing * update comms details in issue templates * add link to contributors guide * point to devel for comms
Fixed an incorrect example, where the expected output given had evidently been copied from an earlier example accidentally. PR #84684
Previously, the integration test depended on luck. `setuptools` used to be bundled in Python stdlib's `ensurepip`. Python 3.12 and newer no longer include it. This test imports `pkg_resources` that is a part of `setuptools`, meaning that it'll run out of luck at some point, under newer Python runtimes. This test does not seem to be useful to us so instead of fixing it, we remove it from the repo [[1]]. Supersedes #84681. [1]: #84681 (comment)
* Add test case for include_vars * Revise test to catch erroneous warnings
Previously, requirement version specs starting with `!=` were incorrectly considered as pinned release requests because the comparison was being made against a one-char string while the operator is two-char. This patch changes the check to test against `!` which is enough to detect this case.
Changed the URL to Jinja project
* test: enable user test for alpine * Disable user home update tests * Disable some more tests which are not applicable for Alpine Signed-off-by: Abhijeet Kasurde <[email protected]>
Signed-off-by: Abhijeet Kasurde <[email protected]>
* Add openSUSE MicroOS to SUSE family list Co-authored-by: Abhijeet Kasurde <[email protected]>
* Passing maxsplit and flags as positional arguments is deprecated in 3.13. Signed-off-by: Abhijeet Kasurde <[email protected]>
* Link to amazon.aws.aws_ec2 inventory plugin. * Mention that refresh_inventory does not update the selected hosts for a play. * Address comments by bcoca. * Apply suggestions from code review --------- Co-authored-by: Abhijeet Kasurde <[email protected]>
* Fixed various become-related issues in `local` connection plugin. * Fixed various issues in `sudo` and `su` become plugins. * Added unit and integration test coverage. Co-authored-by: Matt Clay <[email protected]> Co-authored-by: Matt Davis <[email protected]>
Signed-off-by: Abhijeet Kasurde <[email protected]>
* Make timeout on become an unreachable error Fixes #84468
No the file name that caused the error will be apparent --------- Signed-off-by: Abhijeet Kasurde <[email protected]> Co-authored-by: Abhijeet Kasurde <[email protected]>
* Ensure implicit flush_handlers have a parent block To avoid getting tracebacks when calling methods like ``get_play()`` on them. * task needs to be copied * copy only when necessary
* Simplify conditional for service_facts integration test This test requires systemd, so just test for that. Also fixes running this on Debian testing/unstable releases, where ansible_distribution_version is "n/a". * Clean up after service_facts integration test * Simplify set_fact in interpreter_discovery_python test Those vars are always set, either to something discovered, or "n/a". There are no evaluations against the value "unknown". * interpreter_discovery_python: Fix Debian test Debian doesn't set VERSION_ID in /etc/os-release on pre-releases, see https://bugs.debian.org/1008735 ansible 2.17 onwards does not support python 2.7 anyway. * fix deb822_repository integration test failure on Debian * Fix integration test hostname for Debian * Fix integration test mount_facts Some VMs might only have a single mount point, so they only have a single UUID. * Add package deps for integration test subversion /usr/bin/htpasswd is shipped in apache2-utils and needed by the main playbook. * Fix integration test "service" on Debian sid Debian sid does not set ansible_distribution_version, as such any tests assuming it's a numeric value will fail. Since this is ancient test code that predates ansible_service_mgr, remove the error-prone heuristic and rely on that var instead. * Fix service integration tests not running on *BSD --------- Co-authored-by: Lee Garrett <[email protected]>
* ansible-test validate-modules - fix ps util checks Fix the module util import checks done by `ansible-test sanity --test validate-modules` to support the newer `#AnsibleRequires` import statement and `-Optional` flag. * Fix sanity issues
Fix up bug when attempting to run any module on a Windows host that has been configured with WDAC and Dynamic Code Security in audit mode. This does not enable WDAC support with signed scripts so Ansible will still not pass the audit events but it no longer fails to run.
* Deprecate strategy plugins. Fixes #84725
Removes the use of pexpect in the winrm connection plugin and rely on just subprocess. In the past pexpect was used for macOS compatibility so that it could handle the TTY prompt but after testing it seems like subprocess with `start_new_session=True` is enough to get it reading from stdin on all platforms. This simplifies the code as there's no longer an optional library changing how things are called and will work out of the box.
* ansible-test - Minor style cleanup (add blank lines) * ansible-test - Use `"""` instead of `'''`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION