Engine support for treating solo frets separately from normal frets #224
Conversation
…r each instrument type
|
We decided a while ago that the change in logic solo buttons provide was something we were not going to have as it provides an advantage over guitars which don't have solo buttons. We've considered this being added as some kind of modifier/engine setting but it's not been thought about too much. |
|
Changed to an engine parameter. Logic changes as suggested on Discord to prevent tap logic being triggered while standard buttons are held. |
These particular ones can get quite spammy, and are only really helpful for developers
Also replace usage of chart event tracker with direct access of tempo list, since we already make that assumption
wyrdough
force-pushed
the
fivefret-solo
branch
from
c62317a to
d1c3619
Compare
…lo tap logic to not trigger when any standard buttons are fretted.
It turns out that IsSoloActive doesn't get set until after the first note of the solo is hit or missed, so SoloTapAllowed now allows a note to be tapped when either IsSoloActive is true or if the note has the IsSoloStart flag.
This fixes an issue where it's way too easy to end up overstrumming when attempting to strum notes fretted with the solo buttons during solos.
wyrdough
force-pushed
the
fivefret-solo
branch
from
d1c3619 to
7108f7f
Compare
There was a problem hiding this comment.
Hello, thanks for the PR!
Please review the comments below for the changes I requested.
After that fix, I just need to know if this conflicts with any changes in the engine-fixes branch and whether or not this can be merged right now, or if we should wait (@RileyTheFox).
| @@ -358,11 +363,31 @@ protected sealed override int CalculateBaseScore() | |||
|
|
|||
| protected void ToggleFret(int fret, bool active) | |||
| { | |||
| // FIXME: This is a terrible hack | |||
| if((int) fret >= 10) { | |||
There was a problem hiding this comment.
Please please please do not use "terrible hacks" within PRs.
Before the big rewrite of v0.12, I made the mistake of merging PRs with hacks in them. They build up over time, and the codebase's quality just plummets because of that.
Unfortunately, because of this, before this PR is merged this needs to be fixed.
There was a problem hiding this comment.
That is there so that the solo frets don't have to be special cased everywhere ButtonMask is used. I called it a hack, but I can't really think of a better way to do it, TBH.
There was a problem hiding this comment.
Ok, I changed it to make the input button mask a ushort to accommodate the extra buttons and then calculate an effective button mask which is a bitwise or of the two sets of buttons to be used where ButtonMask was previously being used so that the solo buttons still act as regular buttons outside of solos.
If you can think of a better strategy here, I'm all ears.
wyrdough
force-pushed
the
fivefret-solo
branch
from
2acb7b6 to
f5f8903
Compare
RileyTheFox
force-pushed
the
engine-fixes
branch
from
17a768b to
416b725
Compare
This PR adds support for solo buttons as found on Rock Band guitars and the Riffmaster.
During a solo section, all notes are treated as if they are tap notes when the solo buttons are used.