[TNT-180] 트레이니 홈 화면 주간 기록 출력 API 연동 #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeonJeongk
changed the title
hoyahozz
approved these changes
Feb 13, 2025
Comment on lines
45
to
46
| val startDate = visibleYearMonth.minusMonths(1).atDay(20).toString() | ||
| val endDate = visibleYearMonth.plusMonths(1).atDay(7).toString() |
There was a problem hiding this comment.
왜 20일과 7일인가용 ?
달 기준 7일을 더하거나 빼는 식으로 읽는 사람을 이해시키는 방법도 있을 것 같아요!
There was a problem hiding this comment.
그러네요..! 수정했습니다🥺
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
Closes [TNT-180] 트레이니의 주간 기록 출력 #43
주간 캘린더에서 PT 수업 또는 기록이 있는 날짜에 Indicator 표시
네트워크 요청 최적화 (캐싱 적용)
월(YearMonth)은 다시 요청하지 않도록 캐싱 적용캘린더 데이터 조회 범위
startDate: 이전 달 20일부터endDate: 다음 달 7일까지📸 실행 화면
TraineeWeeklyData.mp4
🙆🏻 리뷰 요청 사항
화이팅팅..
👀 레퍼런스