-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TNT-114] 회원가입 데이터 취합 및 API 연동 #54
Merged
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
7f245f1
[TNT-114] fix: RoleState 수정
SeonJeongk 6c0a7e2
[TNT-114] feat: 역할 선택 -> 회원가입 네비게이션 연결
SeonJeongk 071a69f
[TNT-114] feat: 트레이너 회원가입 사진, 이름 state로 관리
SeonJeongk 9c37378
[TNT-114] feat: 트레이너 회원가입 사진, 이름 state로 관리
SeonJeongk 8ff993a
[TNT-114] fix: 불필요한 코드 삭제 및 정렬 수정
SeonJeongk c2d814b
[TNT-114] refactor: 트레이너 이름, 사진 설정 관련 이름 수정
SeonJeongk eb79aca
[TNT-114] feat: 트레이니 회원가입 데이터 state로 관리
SeonJeongk bb6d29e
[TNT-114] feat: 회원가입 API 구현
SeonJeongk f942102
[TNT-114] feat: 트레이너 회원가입 API 연결
SeonJeongk e6a14b9
[TNT-114] refactor: 회원가입 주의사항 입력 에러 문구 추가
SeonJeongk b9d0ba9
[TNT-114] feat: 트레이너 회원가입 API 연결
SeonJeongk f3263f6
[TNT-114] fix: 이미지 File을 넘겨주도록 수정 및 state 수정
SeonJeongk a3274b6
[TNT-114] fix: 연결 화면들 preview 오류 수정
SeonJeongk 6201215
[TNT-114] fix: SignUpRequest 매핑 수정
SeonJeongk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요 클래스에서
UserType
에 대한 확장 함수를 가지고 있는건 너무 어색해보입니다..!SignUpRequest.fromDomain
이나,SignUpRequest.fromUserType
과 같은 형태가 맞는 것 같아요!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵..! 다시 수정해보겠습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
지금 제 코드는
UserType
을 기반으로 새로운SignUpRequest
객체를 생성하는 방식이라 SignUpRequest에 대한 확장 함수로 구현하기는 어려울 것 같습니다..!companion object를 이용해
fromUserType
을 구현하는건 안 될까요?😨There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
얽 이거
Request
인데 제가 놓쳤네요 '-' ;;혼동드려서 죄송합니다 ㅜㅜ
수정해주신대로 진행해도 될 것 같습니다ㅠㅠㅠ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그럼 지금 코드대로 머지하겠습니다!!