[TNT-140] DataStore 구축 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeonJeongk
approved these changes
Jan 25, 2025
Comment on lines
+12
to
+15
| @Singleton | ||
| class SessionDataSource @Inject constructor( | ||
| private val sessionPreferences: DataStore<Preferences>, | ||
| ) { |
There was a problem hiding this comment.
로컬 저장 용도로 DataStore 사용할 때 DataSource를 나누는 기준은 어떻게 될까요?!
예를들어 SessionDataStore가 세션 관련 데이터를 관리하고 있는 것처럼 데이터의 용도에 따라 나누면 될까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
Closes [TNT-140] DataStore 구축 #21
DataStore를 구축하였습니다.data:storage모듈 내 위치합니다.storage라고 명명한 이유는,datastore,preferences와 같이 내부 저장소 라이브러리의 이름을 명시하고 싶지 않았기 때문입니다.dataStore보다 더 좋은 라이브러리가 생길 수도 있는데, 그렇게 되면 모듈명 자체를 변경해야 합니다. (물론 큰 여파는 없을 것 같지만요..):data모듈 계층을 변경하였습니다.:data:data:repository<-:data:network,:data:storagerepository는 여러datasource들을 취합하여 애플리케이션에 적합한 형태로 데이터를 매핑하는 역할을 맡고 있습니다.datasource들을 가지고 있는 모듈과repository모듈을 분리하여 역할을 명시하였습니다.📸 실행 화면
🙆🏻 리뷰 요청 사항
👀 레퍼런스