[TNT-114] fix: PR 리뷰 반영

YAPP-Github · Jan 26, 2025 · 13ecc67 · 13ecc67
1 parent a193d4e
commit 13ecc67
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 14 deletions.
diff --git a/core/designsystem/src/main/java/co/kr/tnt/designsystem/component/TextField.kt b/core/designsystem/src/main/java/co/kr/tnt/designsystem/component/TextField.kt
@@ -296,9 +296,9 @@ fun TnTOutlinedTextField(
             verticalAlignment = Alignment.CenterVertically,
             modifier = Modifier.padding(vertical = 8.dp),
         ) {
-            if (isError && !warningMessage.isNullOrEmpty()) {
+            if (isError && warningMessage.isNullOrEmpty().not()) {
                 Text(
-                    text = warningMessage,
+                    text = warningMessage ?: "",
                     style = TnTTheme.typography.body2Medium,
                     color = counterColor,
                 )

diff --git a/feature/trainee/signup/src/main/java/co/kr/tnt/trainee/signup/TraineeBasicInfoPage.kt b/feature/trainee/signup/src/main/java/co/kr/tnt/trainee/signup/TraineeBasicInfoPage.kt
@@ -64,7 +64,7 @@ fun TraineeBasicInfoPage(
     val isFormValid by remember { derivedStateOf { isHeightValid && isWeightValid } }
 
     Scaffold(
-        topBar = { TnTTopBarWithBackButton(onBackClick = { onBackClick() }) },
+        topBar = { TnTTopBarWithBackButton(onBackClick = onBackClick) },
         containerColor = TnTTheme.colors.commonColors.Common0,
     ) { innerPadding ->
         Box(modifier = Modifier.padding(innerPadding)) {
@@ -141,7 +141,7 @@ fun TraineeBasicInfoPage(
                 text = stringResource(uiResource.string.next),
                 modifier = Modifier.align(Alignment.BottomCenter),
                 enabled = isFormValid,
-                onClick = { onNextClick() },
+                onClick = onNextClick,
             )
         }
     }

diff --git a/feature/trainee/signup/src/main/java/co/kr/tnt/trainee/signup/TraineeNoteForTrainerPage.kt b/feature/trainee/signup/src/main/java/co/kr/tnt/trainee/signup/TraineeNoteForTrainerPage.kt
@@ -41,7 +41,7 @@ fun TraineeNoteForTrainerPage(
     var text by remember { mutableStateOf("") }
 
     Scaffold(
-        topBar = { TnTTopBarWithBackButton(onBackClick = { onBackClick() }) },
+        topBar = { TnTTopBarWithBackButton(onBackClick = onBackClick) },
         containerColor = TnTTheme.colors.commonColors.Common0,
     ) { innerPadding ->
         Box(modifier = Modifier.padding(innerPadding)) {
@@ -72,7 +72,7 @@ fun TraineeNoteForTrainerPage(
             TnTBottomButton(
                 text = stringResource(uiResource.string.next),
                 modifier = Modifier.align(Alignment.BottomCenter),
-                onClick = { onNextClick() },
+                onClick = onNextClick,
             )
         }
     }

diff --git a/feature/trainee/signup/src/main/java/co/kr/tnt/trainee/signup/TraineePTPurposePage.kt b/feature/trainee/signup/src/main/java/co/kr/tnt/trainee/signup/TraineePTPurposePage.kt
@@ -47,7 +47,7 @@ fun TraineePTPurposePage(
     var selectedPurposes by remember { mutableStateOf(setOf<PTPurpose>()) }
 
     Scaffold(
-        topBar = { TnTTopBarWithBackButton(onBackClick = { onBackClick() }) },
+        topBar = { TnTTopBarWithBackButton(onBackClick = onBackClick) },
         containerColor = TnTTheme.colors.commonColors.Common0,
     ) { innerPadding ->
         Box(modifier = Modifier.padding(innerPadding)) {
@@ -82,7 +82,7 @@ fun TraineePTPurposePage(
             }
             TnTBottomButton(
                 text = stringResource(uiResource.string.next),
-                onClick = { onNextClick() },
+                onClick = onNextClick,
                 enabled = selectedPurposes.isNotEmpty(),
                 modifier = Modifier.align(Alignment.BottomCenter),
             )

diff --git a/feature/trainee/signup/src/main/java/co/kr/tnt/trainee/signup/TraineeProfileSetupPage.kt b/feature/trainee/signup/src/main/java/co/kr/tnt/trainee/signup/TraineeProfileSetupPage.kt
@@ -70,7 +70,7 @@ fun TraineeProfileSetupPage(
     )
 
     Scaffold(
-        topBar = { TnTTopBarWithBackButton(onBackClick = { onBackClick() }) },
+        topBar = { TnTTopBarWithBackButton(onBackClick = onBackClick) },
         containerColor = TnTTheme.colors.commonColors.Common0,
     ) { innerPadding ->
         Box(modifier = Modifier.padding(innerPadding)) {
@@ -120,7 +120,7 @@ fun TraineeProfileSetupPage(
             TnTBottomButton(
                 text = stringResource(uiResource.string.next),
                 enabled = text.isNotBlank() && !isWarning,
-                onClick = { onNextClick() },
+                onClick = onNextClick,
                 modifier = Modifier.align(Alignment.BottomCenter),
             )
         }

diff --git a/feature/trainee/signup/src/main/java/co/kr/tnt/trainee/signup/TraineeSignUpCompletePage.kt b/feature/trainee/signup/src/main/java/co/kr/tnt/trainee/signup/TraineeSignUpCompletePage.kt
@@ -77,7 +77,7 @@ fun TraineeSignUpCompletePage(
             }
             TnTBottomButton(
                 text = stringResource(uiResource.string.start),
-                onClick = { onNextClick() },
+                onClick = onNextClick,
                 modifier = Modifier.align(Alignment.BottomCenter),
             )
         }

diff --git a/feature/trainer/signup/src/main/java/co/kr/tnt/trainer/signup/TrainerProfileSetupPage.kt b/feature/trainer/signup/src/main/java/co/kr/tnt/trainer/signup/TrainerProfileSetupPage.kt
@@ -70,7 +70,7 @@ fun TrainerProfileSetupPage(
     )
 
     Scaffold(
-        topBar = { TnTTopBarWithBackButton(onBackClick = { onBackClick() }) },
+        topBar = { TnTTopBarWithBackButton(onBackClick = onBackClick) },
         containerColor = TnTTheme.colors.commonColors.Common0,
     ) { innerPadding ->
         Box(modifier = Modifier.padding(innerPadding)) {
@@ -122,7 +122,7 @@ fun TrainerProfileSetupPage(
                 text = stringResource(uiResource.string.next),
                 modifier = Modifier.align(Alignment.BottomCenter),
                 enabled = text.isNotBlank() && !isWarning,
-                onClick = { onNextClick() },
+                onClick = onNextClick,
             )
         }
     }

diff --git a/feature/trainer/signup/src/main/java/co/kr/tnt/trainer/signup/TrainerSignUpCompletePage.kt b/feature/trainer/signup/src/main/java/co/kr/tnt/trainer/signup/TrainerSignUpCompletePage.kt
@@ -77,7 +77,7 @@ fun TrainerSignUpCompletePage(
             }
             TnTBottomButton(
                 text = stringResource(uiResource.string.start),
-                onClick = { onNextClick() },
+                onClick = onNextClick,
                 modifier = Modifier.align(Alignment.BottomCenter),
             )
         }