display image in better way #607
Open
+69
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosinghal
reviewed
Mar 6, 2025
| $html .= !empty($attachment['icon']) ? '<img src="' . $attachment['icon'] . '" />' : ''; | ||
| $html .= '<span>' . $attachment['name'] . '</span>'; | ||
| if (isset($attachment['mime']) && strpos($attachment['mime'], 'image') !== false) { | ||
| $html .= !empty($attachment['icon']) |
There was a problem hiding this comment.
Worth moving !empty($attachment['icon']) to line 990
| $html .= !empty($attachment['icon']) | ||
| ? '<img src="' . | ||
| $attachment['icon'] . | ||
| '" style="max-height: 240px; |
There was a problem hiding this comment.
Can we please add a class for this instead of inline styling?
includes/events/event-builder.php
Outdated
| @@ -987,8 +987,18 @@ private function get_attachments($attachments) | |||
| foreach ($attachments as $attachment) { | |||
| $html .= '<li class="simcal-attachment">'; | |||
| $html .= '<a href="' . $attachment['url'] . '" target="_blank">'; | |||
| $html .= !empty($attachment['icon']) ? '<img src="' . $attachment['icon'] . '" />' : ''; | |||
| $html .= '<span>' . $attachment['name'] . '</span>'; | |||
| if (isset($attachment['mime']) && strpos($attachment['mime'], 'image') !== false) { | |||
There was a problem hiding this comment.
Let's move this part to a new shortcode cover_image
includes/events/event-builder.php
Outdated
| @@ -987,8 +987,18 @@ private function get_attachments($attachments) | |||
| foreach ($attachments as $attachment) { | |||
| $html .= '<li class="simcal-attachment">'; | |||
| $html .= '<a href="' . $attachment['url'] . '" target="_blank">'; | |||
| $html .= !empty($attachment['icon']) ? '<img src="' . $attachment['icon'] . '" />' : ''; | |||
| $html .= '<span>' . $attachment['name'] . '</span>'; | |||
| if (isset($attachment['mime']) && strpos($attachment['mime'], 'image') !== false) { | |||
There was a problem hiding this comment.
Do test if it does not run on core plugin since we can't have drive access there
| $response_arr = json_decode($response, true); | ||
|
|
||
| if (isset($response_arr['response']) && !empty($response_arr['response'])) { | ||
| if ($response_arr['response']) { |
| ]; | ||
| return $response; | ||
| } | ||
| $response = [ |
There was a problem hiding this comment.
No need since it will be unreachable code
| $send_data = [ | ||
| 'site_url' => self::$my_site_url, | ||
| 'auth_token' => get_option('simple_calendar_auth_site_token'), | ||
| 'arguments' => $args, |
There was a problem hiding this comment.
Suggested change
| 'arguments' => $args, | |
| 'arguments' => [ | |
| 'attachments' => $args['attachments'] | |
| ], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Display event attahcment image in better way by showing image rather then just name and link.
Clickup: https://app.clickup.com/t/86cxwtak1
Before & after: https://www.screenpresso.com/=HG0kuVJR8zzv