[AutoBump] Merge with fixes of c1892de6 (Dec 05) (128) #518
+479
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConvOp defined with padding = "same"/"valid" produces the padding variant of the op, such as `conv2d.padding` for 2d convolution. This PR adds these conv variations to torch-mlir registry and a decomposition of these ops to `aten.convolution` to be able to go through the different pass pipelines.
This commit disables the LTC build from the Torch-MLIR CI since after the recent GH runner version upgrade the Torch-MLIR build in CI is failing with an LTC related error. The tracking issue for the same can be found here: llvm#3910 Signed-off-by: Vivek Khandelwal <[email protected]>
) Dense Resources cannot have `-` characters as part of the resource keys. Many ONNX models, however, do have these characters in `TensorProto` or initializer names. This patch adds an unconditional replace function in the sanitization of initializer names that replaces all `-` characters with `_` (underscores) when the dense resources are created, which allows successful parsing of the IR. In case the name was legal before sanitization, the function has no effect. Unnecessary additional time complexity is avoided by omitting an `if` condition to check containment.
Refactors llvm#3901 by merging illegal character sanitization into the regex and removing call to `replace()`.
jorickert
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.