-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analytical FIFO sizing #1185
Open
lstasytis
wants to merge
10
commits into
Xilinx:dev
Choose a base branch
from
lstasytis:feature/analytical-fifo-sizing
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Analytical FIFO sizing #1185
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
bf872a0
analytical fifo sizing functions for: channelwise_op, convolutioninpu…
lstasytis 17dffa3
fixed docker scripts
140ec15
clean up
4df80fa
remove run-docker personalization code
0efe48b
faulty base branch update removed
a6e30e1
faulty base branch update removed, 2
27407b5
structural overhaul and fmpadding characterization fixes
bdc3912
moved fifo sizing tests to respective node tests, failing = threshold…
lstasytis aaa498b
initial updates based on Felix's comments
2a0f0c9
roll back debugging-changes
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -166,12 +166,17 @@ def get_verilog_top_module_intf_names(self): | |
) | ||
return intf_names | ||
|
||
def derive_characteristic_fxns(self, period): | ||
def derive_characteristic_fxns( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This refactoring also needs to be applied to addstreams.py. |
||
self, model, period, strategy, fpga_part, clk_period, op_type, override_dict=None | ||
): | ||
n_inps = np.prod(self.get_folded_input_shape()[:-1]) | ||
io_dict = { | ||
"inputs": { | ||
"in0": [0 for i in range(n_inps)], | ||
}, | ||
"outputs": {"out0": [], "out1": []}, | ||
} | ||
super().derive_characteristic_fxns(period, override_rtlsim_dict=io_dict) | ||
|
||
super().derive_characteristic_fxns( | ||
model, period, strategy, fpga_part, clk_period, op_type, override_dict=io_dict | ||
) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DeriveFIFOSizes expects
outFIFODepths
to be set for every output of every CustomOp. This is problematic in the current implementation of DuplicateStreams, as the default value of [2] (=1 output with FIFO depth set to 2) is inherited from HWCustomOp, even though DuplicateStreams hasNumOutputStreams
outputs.How/where do we set the default value of one attribute depending on another attribute without breaking anything? In verify_node()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DeriveFIFOSizes should only get called if derive_characteristic_fxns() has been called for each node already, which are kept in the node definition classes. So I would say the optimal place would be in that same function, like such
I'm not sure why this function had 'out1' and 'out2' defined before, was this for a very specific network? I don't think the generalization should break anything.