Skip to content

Commit

Permalink
[mvu vvu axi]: removed SIMD%2 constraint for double-pumped DSP58
Browse files Browse the repository at this point in the history
  • Loading branch information
mmrahorovic committed Dec 1, 2023
1 parent f38fd6b commit 078888a
Showing 1 changed file with 14 additions and 8 deletions.
22 changes: 14 additions & 8 deletions finn-rtllib/mvu/mvu_vvu_axi.sv
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,13 @@ module mvu_vvu_axi #(
bit M_REG_LUT = 1,

// Safely deducible parameters
localparam int unsigned WEIGHT_STREAM_WIDTH_BA = (PE*SIMD*WEIGHT_WIDTH+7)/8 * 8,
localparam int unsigned INPUT_STREAM_WIDTH_BA = ((IS_MVU ? 1 : PE) * SIMD * ACTIVATION_WIDTH + 7) / 8 * 8,
localparam int unsigned WEIGHT_STREAM_WIDTH = PE*SIMD*WEIGHT_WIDTH,
localparam int unsigned INPUT_STREAM_WIDTH = (IS_MVU ? 1 : PE) * SIMD * ACTIVATION_WIDTH,
localparam int unsigned OUTPUT_STREAM_WIDTH_BA = (PE*ACCU_WIDTH + 7)/8 * 8,
localparam bit SIMD_UNEVEN = SIMD % 2
)
(
localparam int unsigned WEIGHT_STREAM_WIDTH = PE * SIMD * WEIGHT_WIDTH,
localparam int unsigned WEIGHT_STREAM_WIDTH_BA = (WEIGHT_STREAM_WIDTH + 7)/8 * 8,
localparam int unsigned INPUT_STREAM_WIDTH = (IS_MVU ? 1 : PE) * SIMD * ACTIVATION_WIDTH,
localparam int unsigned INPUT_STREAM_WIDTH_BA = (INPUT_STREAM_WIDTH + 7)/8 * 8,
localparam int unsigned OUTPUT_STREAM_WIDTH_BA = (PE*ACCU_WIDTH + 7)/8 * 8,
localparam bit SIMD_UNEVEN = SIMD % 2
)(
// Global Control
input logic ap_clk,
input logic ap_clk2x, // synchronous, double-speed clock; only used for PUMPED_COMPUTE
Expand Down Expand Up @@ -128,6 +127,13 @@ module mvu_vvu_axi #(
end
end

// //- Pumping Constraints ---------
// if(PUMPED_COMPUTE) begin
// if(SIMD % 2 != 0) begin
// $error("Odd SIMD=%0d is incompatible with pumped compute.", SIMD);
// $finish;
// end
// end
end

uwire clk = ap_clk;
Expand Down

0 comments on commit 078888a

Please sign in to comment.