-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test (core/float): Enhanced testing of minifloat formats #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickfraser
commented
Dec 19, 2024
@given( | ||
minifloat_format_and_value=random_minifloat_format_and_value( | ||
min_bit_width=4, max_bit_with=10, rand_exp_bias=True)) | ||
@settings(max_examples=10000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Giuseppe5, any thoughts on a good value here? Maybe 1000
is a good compromise between confidence and test time...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do 1K
This reverts commit 448b59e.
nickfraser
requested review from
Giuseppe5
and removed request for
Giuseppe5
December 20, 2024 09:14
nickfraser
changed the title
Enhanced testing of minifloat formats
test (core/float): Enhanced testing of minifloat formats
Dec 20, 2024
nickfraser
commented
Dec 20, 2024
Giuseppe5
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
An enhanced test suite of minifloat formats to address #1126.
Changes Made in this PR
The enhanced test suite generates 10000 random valid minifloat formats / values and checks that Brevitas produces the identical output. Float64 is used for arithmetic to avoid rounding errors in
log2
,exp2
computations.Testing Summary
Tests run and pass locally, e.g.:
Risk Highlight
Only tests added. No change in brevitas code itself. Zero risks IMO.
Checklist
dev
branch.