Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ON-16341: force 2MB huge page allocation to run on 1GB default systems #71

Open
wants to merge 1 commit into
base: v9_0
Choose a base branch
from

Conversation

rdrinkwa-xilinx
Copy link

Allocated 2MB huge pages and 1GB huge pages remains zero. System default set via kernel command line to be 1G.

Before:

[server01:tcpdirect]$ ZF_ATTR="interface=eth0" ./build/bin/zf_apps/static/zfsink -r 192.1.2.3:25000
ERROR: main: ZF_TRY(zfur_addr_bind(ur, ai_local->ai_addr, ai_local->ai_addrlen, NULL, 0, 0)) failed
ERROR: at src/tests/zf_apps//zfsink.c:365
ERROR: rc=-28 (No space left on device) errno=28
Aborted (core dumped)

After

[server01:tcpdirect]$ ZF_ATTR="interface=eth0" ./build/bin/zf_apps/static/zfsink -r 192.1.2.3:25000
# pkt-rate  bandwidth(Mbps)      total-pkts
         0                0                0
^C

@rdrinkwa-xilinx rdrinkwa-xilinx requested a review from a team as a code owner February 21, 2025 15:20
@tcrawley-xilinx
Copy link
Contributor

This is targeting master, should this also go onto v9_0 or v8_1?

@rdrinkwa-xilinx
Copy link
Author

rdrinkwa-xilinx commented Feb 24, 2025

This is targeting master, should this also go onto v9_0 or v8_1?

This was the more general change that would apply for v9 and onwards. There was a significant change for v8 that necessitated a different fix be used and that was applied to that specific branch. Since this was the first implementation I added it to master rather than v9_0 but I can rebase if desired.

Copy link

@matthewr-xilinx matthewr-xilinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look sane.

Would suggest rebasing on top of v9_0 branch (which can then get merged forwards into master) so it doesn't get missed out.

@rdrinkwa-xilinx rdrinkwa-xilinx changed the base branch from master to v9_0 March 7, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants