-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ON-15695: improve developer documentation #53
Open
matthewr-xilinx
wants to merge
1
commit into
Xilinx-CNS:master
Choose a base branch
from
matthewr-xilinx:ON-15695
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
# Contributing guidelines | ||
|
||
Thank you for taking your time to improve TCPDirect. We would appreciate if you | ||
follow the contributing guidelines to make review of changes easier. | ||
|
||
## Submitting changes | ||
|
||
1. Fork TCPDirect repository on https://github.com/Xilinx-CNS/tcpdirect | ||
2. Make local short-lived branch off of public master. | ||
3. Develop on branch locally. Please describe the changes you have made in | ||
the commit messages. | ||
4. Try to follow the coding conventions used in the files you edit. | ||
5. Push branch to your fork of TCPDirect repository. | ||
6. Create a new Pull Request. Please describe what testing you have done. | ||
7. Address review comments. | ||
8. You need to get sign-off of two other developers before the Pull Request | ||
can be merged. | ||
|
||
## Summary of coding conventions | ||
|
||
In general try to follow the style that is used in the file. | ||
Most of the files use: | ||
|
||
1. Line length limit of 79 characters. | ||
2. Two space indentation. | ||
3. C style comments (no C++ style comments). | ||
4. Opening braces are not put on their own line. | ||
5. No space between keyword and bracket. | ||
|
||
For instance, | ||
|
||
```c | ||
/* This is a comment */ | ||
if( ! conditional_expr ) { | ||
statement1; | ||
statement2; | ||
} | ||
``` | ||
|
||
## Footnotes | ||
|
||
```yaml | ||
SPDX-License-Identifier: MIT | ||
SPDX-FileCopyrightText: Copyright (C) 2020-2024 Advanced Micro Devices, Inc. | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
doc/LICENSE |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
# TCPDirect | ||
|
||
AMD TCPDirect is highly accelerated network middleware. It uses similar techniques to Onload, but delivers lower latency. In order to achieve this, TCPDirect supports a reduced feature set and uses a proprietary API. | ||
|
||
AMD TCPDirect should be used with corresponding versions of Onload®️ at https://github.com/Xilinx-CNS/onload. | ||
|
||
|
||
## Features | ||
|
||
* User-space: TCPDirect can be used by unprivileged user-space applications. | ||
* Kernel bypass: Data path operations do not require system calls. | ||
* Low CPU overhead: Data path operations consume very few CPU cycles. | ||
* Low latency: Suitable for low latency applications. | ||
* High packet rates: Supports millions of packets per second per core. | ||
* Zero-copy: Particularly efficient for filtering and forwarding applications. | ||
* Flexibility: Supports many use cases. | ||
|
||
|
||
## Installation and Quick Start Guide | ||
|
||
Recent releases of TCPDirect are distributed as source code. Instructions for building, packaging and installing may be found in [DEVELOPING.md](DEVELOPING.md) | ||
|
||
|
||
## Support | ||
|
||
The publicly-hosted repository is a community-supported project. When raising | ||
issues on this repository it is expected that users will be running | ||
from the head of the git tree to pick up recent changes. | ||
|
||
Supported releases of TCPDirect are available from | ||
<https://www.xilinx.com/support/download/nic-software-and-drivers.html#tcpdirect>. | ||
Please raise issues on _supported releases_ of TCPDirect with | ||
<[email protected]>. | ||
|
||
|
||
## Contributions | ||
|
||
Please see [CONTRIBUTING.md](CONTRIBUTING.md) | ||
|
||
|
||
## Footnotes | ||
|
||
```yaml | ||
SPDX-License-Identifier: MIT | ||
SPDX-FileCopyrightText: Copyright (C) 2020-2024 Advanced Micro Devices, Inc. | ||
``` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to encourage people to run the ZF unit tests, as well as testing their specific feature?