compat: avoid fortify memcpy/memmove warnings on linux>=6.11 #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid false-positive warnings like: memcpy: detected field-spanning write (size 1436) of single field "dest" at src/lib/transport/ip/tcp_tx_reformat.c:74 (size 0) Since actual allocation is bigger than ci_ip_pkt_fmt struct size, it is safe to copy beyond the struct. Use unsafe_memcpy()/unsafe_memmove() for copying to ci_ip_pkt_fmt struct in a few places, which trigger the warning: ci_tcp_tx_merge_segment(), ci_tcp_rx_pkt_coalesce() and do_copy_from_user(). Signed-off-by: Sergey Nikitin <[email protected]>
ol-alexandra
approved these changes
Feb 26, 2025
ligallag-amd
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid false-positive warnings like:
memcpy: detected field-spanning write (size 1436) of single field "dest" at src/lib/transport/ip/tcp_tx_reformat.c:74 (size 0)
Since actual allocation is bigger than ci_ip_pkt_fmt struct size, it is safe to copy beyond the struct.
Use unsafe_memcpy()/unsafe_memmove() for copying to ci_ip_pkt_fmt struct in a few places, which trigger the warning:
ci_tcp_tx_merge_segment(), ci_tcp_rx_pkt_coalesce() and do_copy_from_user().