Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mcp_playwright): add more control to the headless conf #932

Merged
merged 16 commits into from
Jan 22, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,12 @@ private static Page ensureBrowser(Integer width, Integer height, Boolean headles
playwright = Playwright.create();
}
if (browser == null) {
String headlessProp = System.getProperty("playwright.headless");
boolean isHeadless = headlessProp != null
? Boolean.parseBoolean(headlessProp)
: (headless != null ? headless : false);
browser = playwright.chromium().launch(new BrowserType.LaunchOptions()
.setHeadless(headless != null ? headless : false));
.setHeadless(isHeadless));
}
if (page == null || page.isClosed()) {
page = browser.newPage(new Browser.NewPageOptions()
Expand Down
Loading