Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct installation script errors in readme #633

Closed
wants to merge 1 commit into from

Conversation

rccoder
Copy link

@rccoder rccoder commented Jan 12, 2025

No description provided.

@rccoder rccoder changed the title fix(docs): correct installation script errors in readme docs: correct installation script errors in readme Jan 12, 2025
@nuomi1
Copy link

nuomi1 commented Jan 13, 2025

I think it's better to change to /path/to/config.

@topsworld topsworld requested a review from SusanPhevos January 13, 2025 07:49
@CLAassistant
Copy link

CLAassistant commented Jan 17, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@SusanPhevos SusanPhevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first input parameter of install.sh is the config path. See the script usage. Specifying the absolute path is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants