カスタムルールのコンパイル後にprettierでフォーマットする #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walkthroughこのプルリクエストでは、ESLintの設定ファイル Changes
Possibly related issues
Possibly related PRs
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
package.json (1)
15-16: スクリプトのエラーハンドリングを改善することを推奨しますコンパイルとフォーマットを分離したのは良い改善ですが、エラーハンドリングを追加することを推奨します。
以下のような変更を提案します：
- "custom-rule:tsc": "tsc --project settings/rules/tsconfig.json", - "custom-rule:format": "prettier --write settings/rules/dist/**", + "custom-rule:tsc": "tsc --project settings/rules/tsconfig.json || exit 1", + "custom-rule:format": "prettier --write settings/rules/dist/** || echo 'Formatting failed' && exit 1",この変更により：
- コンパイルエラー時に明確にビルドが失敗します
- フォーマットエラー時にも適切なエラーメッセージが表示されます
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
settings/rules/dist/helpers/astHelpers.jsis excluded by!**/dist/**
📒 Files selected for processing (4)
eslint.config.mjs(1 hunks)package.json(1 hunks)settings/rules/src/helpers/astHelpers.ts(1 hunks)settings/rules/src/store-state-suffix.ts(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- settings/rules/src/store-state-suffix.ts
- settings/rules/src/helpers/astHelpers.ts
🔇 Additional comments (2)
eslint.config.mjs (1)
11-11: ESLint の無視設定の変更を確認してください
settings/rules/**/* を ignores から削除することで、コンパイル後のカスタムルールに対して ESLint が実行されるようになりました。この変更は意図的なものと思われますが、以下の点を確認してください。
✅ Verification successful
Let me gather more information about the ESLint configuration and the compiled rules.
ESLint の無視設定の変更は適切です
コードベースの分析から、以下の点が確認できました：
- カスタムルールのソースは
settings/rules/src/にあり、コンパイル後のファイルはsettings/rules/dist/に出力されます settings/rules/index.jsを通じてカスタムルールが ESLint に正しく登録されていますcoding-rules/store-state-suffixルールが設定で有効化されています
ignores からの settings/rules/**/* の削除は意図的で適切な変更です。これにより、コンパイルされたカスタムルールに対して ESLint が実行され、コード品質が向上します。
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify if the custom rules are properly linted after compilation
# Check if ESLint is running on the compiled rules
eslint settings/rules/dist/** --print-config .eslintrc.json | jq '.ignores'
# Verify the existence of compiled rules
ls -la settings/rules/dist/
Length of output: 658
Script:
#!/bin/bash
# Check the content of eslint.config.mjs to understand the current configuration
cat eslint.config.mjs
# Check if there are any ESLint related files in the settings/rules directory
fd -t f -e js -e ts -e mjs -e cjs . settings/rules/
# Check if there are any ESLint configurations in package.json
cat package.json | jq '.eslintConfig, .devDependencies | select(.!=null)'
Length of output: 3019
package.json (1)
7-7: スクリプト名の変更は適切です
build:custom-lint から build:custom-rule への名前変更は、機能をより正確に表現しており、良い変更です。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #80
Summary by CodeRabbit
build:custom-lintからbuild:custom-ruleに変更しました。