Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports iOS 18+ runtime downloads #391

Merged
merged 6 commits into from
Oct 30, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Updated some error descriptions
MattKiazyk committed Oct 30, 2024
commit d0b01bc907c206505c4d2898a052b749f564b250
4 changes: 2 additions & 2 deletions Sources/XcodesKit/RuntimeInstaller.swift
Original file line number Diff line number Diff line change
@@ -188,7 +188,7 @@ public class RuntimeInstaller {
@MainActor
public func downloadOrUseExistingArchive(runtime: DownloadableRuntime, to destinationDirectory: Path, downloader: Downloader) async throws -> URL {
guard let source = runtime.source else {
throw Error.missingRuntimeSource(runtime.identifier)
throw Error.missingRuntimeSource(runtime.visibleIdentifier)
}
let url = URL(string: source)!
let destination = destinationDirectory/url.lastPathComponent
@@ -364,7 +364,7 @@ extension RuntimeInstaller {
case .rootNeeded:
return "Must be run as root to install the specified runtime"
case let .missingRuntimeSource(identifier):
return "Runtime \(identifier) is missing source url. Downloading of iOS 18 runtimes are only supported using Xcode 16.1+ and can only be installed, not just downloaded."
return "Downloading runtime \(identifier) is not supported at this time. Please use `xcodes runtimes install \"\(identifier)\"` instead."
case let .xcode16_1OrGreaterRequired(version):
return "Installing this runtime requires Xcode 16.1 or greater to be selected, but is currently \(version.description)"
case .noXcodeSelectedFound: