Migrate Redis tests to Testcontainers #2345
Merged
+53
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull request includes several changes to integrate Testcontainers for Redis in the health checks testing suite. The most important changes include adding a new fixture for Redis containers, updating test cases to use the fixture, and modifying configuration files to include the new dependencies.
Integration of Testcontainers for Redis:
test/HealthChecks.Redis.Tests/RedisContainerFixture.cs
: Added a new fixture classRedisContainerFixture
to manage the lifecycle of a Redis container using Testcontainers.test/HealthChecks.Redis.Tests/RedisContainerImageTags.cs
: Added a static classRedisContainerImageTags
to define constants for the Redis container image tags.Updates to test cases:
test/HealthChecks.Redis.Tests/Functional/RedisHealthCheckTests.cs
: Modified test cases to use theRedisContainerFixture
for obtaining the Redis connection string instead of hardcoding it. [1] [2] [3] [4]Configuration changes:
.github/workflows/healthchecks_redis_ci.yml
: Removed the Redis service configuration from the CI workflow.Directory.Packages.props
: Added theTestcontainers.Redis
package version.build/versions.props
: Defined theTestcontainersVersion
property.test/HealthChecks.Redis.Tests/HealthChecks.Redis.Tests.csproj
: Added a package reference forTestcontainers.Redis
.Which issue(s) this PR fixes:
Contributes to #2335
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Please make sure you've completed the relevant tasks for this PR, out of the following list: