-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sourcery refactored master branch #1
base: master
Are you sure you want to change the base?
Conversation
Run & review this pull request in StackBlitz Codeflow. |
print(">> {}".format(data)) | ||
print(f">> {data}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function PipeTransport.receive_message
refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting
)
print("<< {}".format(reply)) | ||
self.output.write("{}\n".format(reply)) | ||
print(f"<< {reply}") | ||
self.output.write(f"{reply}\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function PipeTransport.send_reply
refactored with the following changes:
- Replace call to format with f-string [×2] (
use-fstring-for-formatting
)
if not isPassword: | ||
return {"text": input()} | ||
|
||
return "" | ||
return {"text": input()} if not isPassword else "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function StdIOHandler.onInputRequired
refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else
) - Replace if statement with if expression (
assign-if-exp
)
print("cmd: {}".format(" ".join(cmd))) | ||
print(f'cmd: {" ".join(cmd)}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function main
refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting
)
Branch
master
refactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
master
branch, then run:Help us improve this pull request!