Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to download dialogue data from Voices of Wynn and convert to json #103

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

magicus
Copy link
Member

@magicus magicus commented Apr 8, 2024

Unfortunately the Voices of Wynn project lacks a simple machine-readable index of all their recordings and how they match to quest lines. Instead this is generated at run-time by a Java class (which in turn is replaced during build by some gradle magic).

This PR downloads that Java file and tries to parse it into a json file, containing the same information but in a way that is more accessible.

(Ideally, I think VoW should use something like this internally, instead of having a Java class. I might want to try to publish a PR for them that takes this files and reads it with GSON, instead of the current Java solution.)

For the moment, this file is not used, but my idea is to do two things:

  1. hook it up with our crowdsourcing abilities, to get verification that the quest lines are correct, and report new quest lines

  2. add VoW integration into Wynntils, so we can download and play the sounds

Before this goes live, we should sync with VoW so they are okay with this.

@kristofbolyai
Copy link
Member

Honestly, I would much rather have our own collection... I had a plan to collect all dialogues with color codes (VoW doesn't have color codes collected..). Then, I can translate these dialogues with color codes once, and put it on some server. That means, we can have PRs correcting bad translations, and overall translation quality and performance would be better. Aaand, VoW can use it too, they just strip colors.

@kristofbolyai
Copy link
Member

What's your motivation behind this? Do you want to fix VoW, do you want to integrate it?

@magicus
Copy link
Member Author

magicus commented Apr 8, 2024

My intention is to be able to integrate VoW into Wynntils. For this, I need to be able to map dialogues with their filenames. This is basically a port of how they do it themselves to a format that we can use.

I think VoW could do things better, and they might (or might not) appreciate any support from us to help them make it better.

But as a starting point I'd just like to be able to get integration of the VoW recordings into Wynntils, just as if you had downloaded their mod.

@magicus
Copy link
Member Author

magicus commented Apr 8, 2024

So this is basically a way of getting an id for each quest line that they support. The id can then be used to determine the proper file to download and play.

@kristofbolyai
Copy link
Member

Okay, go ahead, I'm sure you can figure out a way to do this in Wynntils.

@magicus
Copy link
Member Author

magicus commented Apr 8, 2024

I've been thinking about this for a while, and the first major blocker was just this -- how to get to their filenames. The quality of the data is not poor, but I found a few suspect entries during processing, so I suspect not all entries will match during gameplay. (Another option is that Wynn itself sends out inconsistent dialogues.)

But improving that is a separate project.

@magicus
Copy link
Member Author

magicus commented Apr 8, 2024

I'm not sure when I can continue working on this, but it's been itching me for a while that I did not have this json data, and today I decided to spend some hours on fixing it. Still, as I said, before I push this I want to check with VoW so they are okay with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants