Skip to content

Commit

Permalink
Make build target naming consistent
Browse files Browse the repository at this point in the history
  • Loading branch information
mluypaert committed Jan 25, 2024
1 parent 069ff77 commit 8a7d6b5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,9 @@ build: ENV.VERSION_TAG clean build/ ui-build build/${DEPLOY_JAR} \
@docker build -t ${ECR_REPO_NAME}:${VERSION_TAG} \
--build-arg uberjar_path=build/${DEPLOY_JAR} .

.PHONY: ui-build
ui-build: ENV.GOOGLE_OAUTH_CLIENT_ID \
$(call print-help,ui-build,\
.PHONY: build-ui
build-ui: ENV.GOOGLE_OAUTH_CLIENT_ID \
$(call print-help,build-ui,\
Build JS and CSS file for release.)
@ export REACT_APP_GOOGLE_OAUTH_CLIENT_ID=${GOOGLE_OAUTH_CLIENT_ID} && \
echo "Building UI using APP_PROFILE: '${APP_PROFILE}'" && \
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ Correct functionality of the client app can be tested in two ways:
- Making a production build of the client app. Failure during this process means fixes will be needed before deployment.
```bash
# performs a npm clean install of dependencies based on package-lock.json
make ui-build
make build-ui
```

To start up a local client development server:<a id="local-rest"></a>
Expand Down Expand Up @@ -299,7 +299,7 @@ To deploy an update for the main application, change your working dir
to the repository root dir and execute the following commands (bash):
```bash
# Build the client application to ensure no errors occur.
make ui-build APP_PROFILE=prod
make build-ui APP_PROFILE=prod
# Generate the pom.xml file (not version-controlled)
# to ensure no errors occur (in API code)
Expand Down

0 comments on commit 8a7d6b5

Please sign in to comment.